Alexander,
Your fix looks good to me.
Thank you,
William
Alexander Eremin wrote:
> On Wed, 2009-10-14 at 13:25 +0200, William Schumann wrote:
>
>> Alexander,
>> The code assumes that if prtvtoc fails for any reason, that format(1m)
>> should write the vtoc. I am not sure how solid an assumption this is,
>> but it seems reasonable.
>>
>> What does the 'dd' command accomplish, zeroing the 1st 16 blocks of
>> slice 0 as shown in the example below on a volume that has no vtoc?
>> Please explain how this works.
>>
>> The boolean_t disk_is_unlabeled is unnecessary. The code to invoke
>> format -d to write the label should be within the block in which
>> disk_is_unlabeled is set.
>>
>> Since a disk is being labeled, please clearly comment the code and add a
>> log message stating that the format command was used to label the disk.
>>
>> Thank you,
>> William
>>
>
> Hi William,
> fixed and updated http://cr.opensolaris.org/~alhazred/3136/
>
> Regards,
>
>
> ::alhazred
>
