Alexander Eremin wrote: > I need review for Bug 3136 - TI fails to create VTOC on unlabeled disk > on Sparc. > > webrev : http://cr.opensolaris.org/~alhazred/3136/ >
A couple of thoughts... The return code from prtvtoc(1M) is not currently a documented/stable interface, but you are relying on it as though it was, and also assuming the only meaning is an unlabeled disk, which seems unlikely. Personally, I would use format -f so you don't have to feed in the "y" and "q". I suspect you can do this with something like: "echo 'label' | /usr/sbin/format -f /dev/fd/0 -d %s" but I haven't tried it (haven't got a spare drive to zap). -- Andrew
