Glenn Lagasse wrote:
> The VMC project is proud to present it's code for your review. You may
> access the webrev at:
>
> http://cr.opensolaris.org/~glagasse/slim_vmc/
>
> I'm also attaching the DC log file for a VMC run as well as the console
> output for the same run for the curious as to what this looks like in
> practice.
>
> The timeout for providing review comments is COB October 23rd, 2009. If
> you need more time, please let me know.
>
> Thanks!
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Glenn,
usr/src/cmd/distro_const/DC-manifest.rng:
Is there a reason why vmc fields are commented in the schema files
(lines 65-67, 299-305). Are these definitions are not used or not needed?
DC_defs.py:
You got me confused here. Changing DISTRO_PARAMS -> IMG_PARAMS and
IMG_PARAMS->DISTRO_PARAMS ;-)
usr/src/cmd/distro_const/utils/im_pop.py:
General comments: The pkg set-authority is changed to set-publisher. Do
we need to convert authority to published for this project?
80: Why you have a 'pass' here?
107: Can you add some comments to the function 'dc_ips_unset_auth'
180, 188, 197, 208, 220: Comments the functions in those lines
315: publisher is used here and authority is used in all other places
usr/src/cmd/distro_const/vmc/create_vm:
201: The error message could be more descriptive with usage
215: If DISKSIZE is non-numeric, why you are continuing?
221: same comment as in line 215 for RAM_SIZE
238: Add the unit to the message like 12000 MB
244: Same as the above comment
usr/src/cmd/distro_const/vmc/export_esx:
170: The comments indicate 7 args passed to this script but the line
checks only for 5 args?
218-233: They are same here and create_vm. Is it possible to use only
one copy?
usr/src/cmd/distro_const/vmc/export_ovf:
170: The comments indicate 7 args passed to this script but the line
checks only for 5 args?
190: Extra '=' in ${MEDIA=}
usr/src/cmd/distro_const/vmc/post_install_vm_config:
182: The error message could be more descriptive with usage
196: If RAM_SIZE is non-numeric, why you are continuing?
199: RAM_SIZE -->CPUS
202: same comment as in line 196 for CPUs
212: Add the unit to the message like 12000 MB
218: Same as the above comment
- Sundar
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20091014/31172936/attachment.html>
