Hey Jean,
* jeanm (Jean.McCormack at Sun.COM) wrote:
> Thanks Glenn. Glad you explained everything. Only one more comment.
>
> >
> >Really? It verifies fine for me in netbeans (I specifically tried to
> >make this PEP8 compliant). How is it not?
> The indentation looks like it's still 8 spaces. I believe it should be 4.
> It also looks like there are some lines > 79 characters.
Yeah, netbeans unfortunately doesn't do a great job of cleaning this
sort of thing up. And because of the mish-mash of indentation we have
in our code cleaning it up is going to be time-consuming. I tried a
brute-force approach via some vim macros but that ended up breaking
things horribly. If you (or anyone) knows of a python re-indent utility
I'd love to hear about it.
> Not sure if the following is a PEP8 issue or pylint. From what I've
> read though,
> supposedly to be truly PEP8 you need to be pylint clean also. Not clear we
> want that extreme conformance at this point in time.
Good question, I don't know. I'm going to guess and say 'we don't'.
> execfile("/usr/lib/python2.4/vendor-packages/osol_install/distro_const/" \
> "DC_defs.py")
> execfile('/usr/lib/python2.4/vendor-packages/osol_install/transfer_defs.py')
>
> So the above kick out all kinds of errors. I found that doing
> something like this
> helps tremendously and is IMHO more correct (yeah I did the original
> code so I'm
> criticizing myself)
>
> from osol_install.distro_const.DC_defs import IMAGE_INFO_FILE
Thanks, I'll pick this up.
Thanks again Jean!
--
Glenn
