Hi Sarah, Thanks for the review comments! I'll respond to the DC specific comments you raised, I believe Joe covered the finalizer script comments in his response.
* Sarah Jelinek (Sarah.Jelinek at Sun.COM) wrote: > Hi Glenn and Team, > > Great work getting this done! I do have a few comments(don't I > always :-)).... > > If I repeated anything other folks said, just point me to your > responses to them. > > DC-manifest.defval.xml: > -You added the 'skip_if_no_exist' to all of the default values. Is > there a way to set a global macro or something to do this, so we > don't have to add it to every line? Perhaps in DC_defs.py? Not quite > sure if this will work, just checking. Not that I'm aware of. I'd love to be enlightened however. > -Also, I assume "img_params", if not present for standard DC runs > will result in a different failure, not a skip_if_not_present? > Wondering what happens if this node path definition isn't present > for DC runs. If this node path isn't in the manifest, then the manifest validates (distro_const build -l <manifest>) but the build will obviously fail. That's not a great user experience I admit, but I'm unsure how else to structure this. I couldn't find any way to have the XML checks understand that some manifests only need certain sections while others need a different set of sections. > -why did you move/rename the img_params, and distro_const_params? > For example, you included the build_area under the > distro_const_params now. Just wondering. Basically, I needed to move some items around because some items in img_params were actually generic items that all manifests (VMC included) needed vs other items that only made sense when constructing non-VMC images. > DC_checkpoint.py: > -Why did you remove the DC_execute_checkpoint method in this file? I > didn't see this in another module. Did I miss it? Jean answered this one. Thanks Sarah! -- Glenn
