Jack Schwartz wrote:
> Hi Jean.
>
> I checked that you got all instances of "pfinstall", so that part is 
> OK...
>
> I'm wondering about the comment change on line 421 of 
> perform_slim_install.c.  The function in which the comment appears is 
> not "pfinstall", so to me it doesn't seem correct to change 
> "pfinstall" to the name of the current function.  Not sure if it might 
> make more sense just to remove the sentence altogether?
I'll change the sentence to

/*
 * The .sysIDtool.state file needs to be written before the
 * install completes. Update the state here for install
 */

Jean
>
>    Thanks,
>    Jack
>
> On 07/06/09 16:03, Jean McCormack wrote:
>> I'd like a code review for 789 Remove the pfinstall references in 
>> liborchestrator
>>
>> Webrev:
>> http://cr.opensolaris.org/~jeanm/slim_789/
>>
>> CR:
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=789
>>
>> Jean
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>


Reply via email to