Hi Karen, Thanks for the review.
Karen Tung wrote: > Hi Sue, > > All the changes look good to me, except I am slightly concerned about > the method used to determine whether it is a sparc or x86 image > in installadm-common.sh and installadm.c > To determine whether it is a sparc image, you check for the existence of > /platform/sun4v directory in the image. I know we support sun4v now > and that directory will be there. But in the future, if we don't > support sun4v, > then, we will need to change the code. Would it be better to check for > something that will always exist in sparc platform, such as > /usr/lib/sparcv9? /usr/lib is not accessible in the image at this point. I think it's ok to use sun4v. Platforms don't disappear out of that directory very quickly (note entry for Ultra-2). We are already looking in platform/sun4v for wanboot, so if it goes away, we'd need changes anyway. Sue > > --Karen > > Susan Sohn wrote: >> Please review the changes for: >> >> 5787 microroot name shouldn't be ISA specific >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5787 >> >> and >> >> 5789 Sticky bit on bootroot file >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5789 >> >> which are posted at: >> >> http://cr.opensolaris.org/~sohn/5787_5789 >> >> Thanks, >> Sue >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
