Susan Sohn wrote: > Hi Karen, > > Thanks for the review. > > Karen Tung wrote: >> Hi Sue, >> >> All the changes look good to me, except I am slightly concerned about >> the method used to determine whether it is a sparc or x86 image >> in installadm-common.sh and installadm.c >> To determine whether it is a sparc image, you check for the existence of >> /platform/sun4v directory in the image. I know we support sun4v now >> and that directory will be there. But in the future, if we don't >> support sun4v, >> then, we will need to change the code. Would it be better to check for >> something that will always exist in sparc platform, such as >> /usr/lib/sparcv9? > > /usr/lib is not accessible in the image at this point. I think it's ok > to use sun4v. Platforms don't disappear out of that directory very > quickly (note entry for Ultra-2). We are already looking in > platform/sun4v for wanboot, so if it goes away, we'd need changes anyway. > > Sue ah, yes, I forgot that /usr/lib is not accessible in the image yet. The way you have coded it up looks good to me then.
thanks, --Karen
