Hi Clay - verifyXML.py - looks ok. It doesn't look like you made any changes other than to correct the tabbing/spacing?
publish-manifest.py - lines 744 - 746: I'm not sure I understand the significance of calling out the StringIO in the comment, but maybe this is partially because I'm not that familiar with python. Couldn't you just say that the input is a file path? And then say the output is is XML Tree Object on success or raises SystemExit on error and prints the name of the file (if available?). I'm curious - what is the XML Tree object being returned? The rest looks ok. thx, ginnie On 12/08/08 15:46, Clay Baenziger wrote: > Haha, thank you Tim. No it was just to see if my mind was being read. Now > that I know my mind is leaky but only running into the storm drain, here's > the URL: > http://cr.opensolaris.org/~clayb/bug4606/webrev/ > Thank you, > Clay > > On Mon, 8 Dec 2008, Tim Knitter wrote: > > >> Clay, >> >> Does this come with separate URL gift in another thread? ;-) >> >> Thanks >> Tim >> >> >>> Hello, >>> This is a pretty straight forward bug fix for the number of >>> parameters to verifySCmanifest() passed on line 624, and to correctly use >>> a name value passed to verifySCmanifest(). Similarly, I've fixed a >>> formatting/style error on line 40 of verifyXML.py and added more to the >>> comments of verifySCmanifest() and verifyAImanifest(). >>> Thank you, >>> Clay >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > -- Ginnie -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20081210/759cb9ea/attachment.html>
