Hi Ginnie, Yes verifyXML.py just got that tabbing fix.
The reason for calling out the StringIO bits is due how it's different than a generic file object. StringIO emulates a file but using a string as the backing store. In particular, with how errors are currently handled, this means an error message may not be able to have a reasonable user meaningful reference to a file, if the error happens in an XML "file" backed by a StringIO object. The XML Tree object is from the LXML package. To clarify that I changed the wording to LXML XML Tree object. I also standardized the two comments, as I had two different structures which was a mess. Please let me know what you think, the new webrev is at http://cr.opensolaris.org/~clayb/bug4606/webrev1 Thank you, Clay On Wed, 10 Dec 2008, Virginia Wray wrote: > Hi Clay - > > verifyXML.py - looks ok. It doesn't look like you made any changes other > than to correct the tabbing/spacing? > > publish-manifest.py - > lines 744 - 746: > I'm not sure I understand the significance of calling out the StringIO > in the comment, but maybe this is partially because I'm not that > familiar with python. Couldn't you just say that the input is a file > path? And then say the output is is XML Tree Object on success or raises > SystemExit on error and prints the name of the file (if available?). > > I'm curious - what is the XML Tree object being returned? > > The rest looks ok. > > thx, > ginnie > > > > On 12/08/08 15:46, Clay Baenziger wrote: > > Haha, thank you Tim. No it was just to see if my mind was being read. Now > > that I know my mind is leaky but only running into the storm drain, here's > > the URL: > > http://cr.opensolaris.org/~clayb/bug4606/webrev/ > > Thank you, > > Clay > > > > On Mon, 8 Dec 2008, Tim Knitter wrote: > > > > > >> Clay, > >> > >> Does this come with separate URL gift in another thread? ;-) > >> > >> Thanks > >> Tim > >> > >> > >>> Hello, > >>> This is a pretty straight forward bug fix for the number of > >>> parameters to verifySCmanifest() passed on line 624, and to correctly use > >>> a name value passed to verifySCmanifest(). Similarly, I've fixed a > >>> formatting/style error on line 40 of verifyXML.py and added more to the > >>> comments of verifySCmanifest() and verifyAImanifest(). > >>> Thank you, > >>> Clay > >>> _______________________________________________ > >>> caiman-discuss mailing list > >>> caiman-discuss at opensolaris.org > >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > >>> > > _______________________________________________ > > caiman-discuss mailing list > > caiman-discuss at opensolaris.org > > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > > > > -- > > Ginnie > > > > > > > >
