Hi Jean,

Thanks for doing the work.  Here are my comments:

bootroot_archive.py:
- line 65, 105, 115: can we do a os.walk() to get through the list of 
files instead of doing the "find"?
- line 283: perhaps doing a "print" statement here so we know we are 
doing sparc compression.
- line 297: "skipping compression" is not quiet right for sparc, since 
we did the compression already.
people might thinking something is wrong when they see this message.  
Please make it specific for x86.

live-fs-root:
209-214: I believe we don't need these lines.  This is to workaround the 
fact that there's no listcd when
Chris did the work, and also, his image is not on a CD.  We don't need 
this now since we do have a listcd.

--Karen



Jean McCormack wrote:
> Karen and anyone else please review:
>
> http://cr.opensolaris.org/~jeanm/slim_sparc/
>
> I believe the appropriate defect is:
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4230
>
> Yes, I'll need to commit with this for the comments.
>
> Jean
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>   


Reply via email to