Hi Jean.
Here are a few more loose ends...
On 12/11/08 13:30, Jean McCormack wrote:
> Jack,
> Thanks for the code review. Comments are inline. I'm currently testing these
> changes.
>
>> ai_sparc_image.xml:
>>
>> Regarding bootroot file list:
>>
>> - Add var/sadm/install/contents
>>
My mistake on asking you to add var/sadm/install/contents. This would
be needed to pkgadd to the live image, but this will never be the case
for the AI image. Please remove. I believe the other changes I
requested here were valid.
>> Not sure about adding ai_post_bootroot_archive finalizer script:
>> Karen asked why the bootroot didn't have the permissions set the same
>> way; the reason is that this script wasn't in the SPARC manifest;
>> however, things still seemed to work... So I'm wondering why it was
>> needed in the first place, or if maybe it's needed for X86 but not for
>> SPARC...
>>
> Well it's very x86 specific. I believe it shouldn't be there.
>
Just posted the question on #caiman-discuss. Let's see if anyone knows
more about why it's there in the first place, and whether it is needed
for SPARC.
Actually, now I'm wondering if it is even needed for X86... There's a
bug (3839) filed which added setting of the sticky bit, but it had no
explanation of why...
For now, I'll go along with what's there.
>> 263: Changes to files should be done in bootroot_configure, not
>> bootroot_archive.
>>
> Karen and I decided to do this here because it needs the bootroot size
> which is computed in this file.
>
OK.
Thanks,
Jack
>
>
>
>> Thanks,
>> Jack
>>
>> On 12/10/08 12:56, Jean McCormack wrote:
>>
>>> Karen and anyone else please review:
>>>
>>> http://cr.opensolaris.org/~jeanm/slim_sparc/
>>>
>>> I believe the appropriate defect is:
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4230
>>>
>>> Yes, I'll need to commit with this for the comments.
>>>
>>> Jean
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>>>
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20081211/212822a7/attachment.html>
