Susan Sohn wrote: > Hi Rokh, > > Frank and I sat down and went through these assertions together. Here > are our comments. > > General comments: > The text installer will be able to create Extended partitions and > Solaris partitions. The test assertions (e.g., manual_04, > tp_partition_003, and others) assume the ability to create other kinds > of partitions such as pcfs. Assertions that make this assumption > should be revised. For instance, manual_04 could be revised so that > fdisk is used to create the extended/logical partitions. Also, no > partition numbers will be displayed on the text install screens. > Setting a partition to unused should make its size 0. > Hi Sue, I have revised all the assertions based on your comments. For the partition numbers, I just use them to be the identify for partitions. B.T.W. according feedback from Jean, now p1-p4 are primary/extended partitions and p5-p36 are the logical partitions, so I also revised all the assertions using this numbering scheme.
Here I have two questions: 1. Two extended partition problem. As I know that ======================================================================= The GUI installer does allow there to be more than one Solaris partition displayed, but it is reported as an error when the user clicks Next. The user can't proceed until there is one and only one Solaris partition. ======================================================================= Since there only one extended partition can be exist on one disk, so I have a question if text installer check if one extended partition exists, user can't create another primary partition as extended partition? 2. Using F5 delete partition problem Now to delete a partition, I use F5 on the "Select Partition" screen to change a partition type to "unused". Would you please tell me how you implement this. Just change the id of the partition to 0 or a number that represents "unused" or other method? B.T.W. I have added a new slice assertion - tp_slice_008 to test on SPARC when there is no valid vtoc information on the test disk. Would you please take a look at the embedded feedback too. Thanks, -Rokh > manual_04: the user must create a Solaris partition before leaving the > Select Partition screen. I have revised this case. > > tp_partition_006, once the partitions have been set to unused in step > 4, the size should be 0. I have revised this case. > > tp_partition_007: step 6, unused size should be 0. I have revised this case. > > tp_partition_010: Per Frank's email yesterday, you will not be able to > cycle back to Extended, so you might not want this test case. I have deleted this case. Now the tp_partition_010 is a new test case to test that how "Text Installer" deal with unrecognized partitions. I created partitions using id 231,232,233,234 as partitions whose type is not recognized. Would you please help me make sure such partitions will be recognized as "Unknow" partitions by text installer. > > tp_partition_011: Step 5 is invalid. Only Solaris and extended > partitions can be resized. You could delete partition 3 if desired Got it, I revised all the cases that test resizing partitions. In all the Resizing assertions, only the Solaris and extended partitions can be resized. And tp_partition_011 now is designed to test "Resizing primary partition and extended partition". > > tp_partition_012: Per Frank's email yesterday, you will not be able to > do step 3 and step 8. The partition must be empty to resize. I have deleted this case. > > tp_partition_013: step 5 is invalid. Only Solaris and extended > partitions can be resized. Now tp_partition_012 is designed to test "Increasing logical partition", and tp_partition_013 is designed to test "Decreasing logical partition". > > tp_partition_014: steps 3-5 aren't valid. Step 6 is allowed. Also, > note that you would need to create a solaris partition in order to > proceed to the next screen. I have revised this case. > > tp_partition_015: step 3, you can't change pcfs to solaris until > existing solaris partition is deleted. If you switch step 4 to make > solaris partition into unused, and swap steps 3 and 4, that would work. I have revised this case. > > tp_slice_001: Is this test for both x86 and sparc? If so, step 2 > should reference both fdisk partition screen as well as Solaris Slices. Now this case just test sparc. I use tp_partition_002 cover such test on x86. > > tp_slice_002: If you destroy the existing vtoc info, then in x86, you > will not see the slice screens. For the sparc case, you can't create > "default" slices. I have revised this case. Would you please help me review if the assertion is OK. > > tp_slice_003: There are two step 4's. For the second step 4, the size > of slice 0 should be 0. > > tp_slice_004: After much discussion, we believe the outcome should be: > slice 0: size=0 avail=10 > slice 1: size=15, avail=100 > slice 3 size=0, avail = 75 I have revised this case. > > tp_slice_005: Step 4 - you can't create a second ZFS Root pool if one > already exists. Couldn't really review the rest of this case. > > tp_slice_005: Step 4 should reference Select Slice screen, similar to > step 3. I have revised this case. > > Thanks, > Sue > > On 09/23/09 02:11, Rokh Wang wrote: >> Hi, >> Would you please help review the partition and slice assertions for >> the text installer test suite. >> Thanks, >> -Rokh >> >> -------- Original Message -------- >> Subject: partition and slice assertions >> Date: Mon, 21 Sep 2009 17:48:58 +0800 >> From: Rokh Wang <rokh.wang at sun.com> >> To: Sue Sohn <Susan.Sohn at Sun.COM> >> CC: Keith Mitchell <Keith.Mitchell at Sun.COM>, Andre Molyneux >> <Andre.Molyneux at Sun.COM>, install team bj <installzone-bj at sun.com> >> References: <4AB73D82.1040601 at sun.com> >> >> >> >> Hello, >> The attachment is the partition and slice assertions for the text >> installer test suite. >> Would you please help review it. >> >> Thanks, >> -Rokh >> >> > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: partition_slice_assertions_1.00 URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090928/77e49c30/attachment.ksh>
