Matt,
Just some nits:
gui-install/src/__init__.py:
196: Line is not needed
197: No need for the backslash (line continuation works inside of
parenthesis)
text-install/__init__.py
320: Line is not needed
321: backslash
Out of curiousity, why have the exact same code in two different
places? Is there nowhere in install_common this code could go that both
the GUI and TI can call? If not, this solution looks fine to me.
-Drew
On 1/18/12 6:30 AM, Matt Keenan wrote:
Hi,
I'd like to get code review for bug :
7107775 - install: log the /var/adm/messages from the installation
on the target
http://monaco.us.oracle.com/detail.jsf?cr=7107775
Webrev Located at:
https://cr.opensolaris.org/action/browse/caiman/mattman/7107775/
Fix is simply to add a transfer-files checkpoint to both gui-install
and text-installer to facilitate the transfer of /var/adm/messages to
the installed system.
Initial thoughts were this fix would also include the changing of the
default post install log location from
/var/sadm/system/logs
to the preferred :
/var/log/install
However upon evaluation of the work required to do this it dosen't
make sense to implement for an update release. As it's not quite as
straight forward as I thought it would be, quite a lot of changes are
required including all documentation, This change should really be
done in a major release, and thus I've logged another bug to cater for
it.
Testing:
- As fix only impacts GUI and TI, I've built test ISO's containing my
fix and test installed both GUI and TI in a vbox environment,
rebooted the installed VM's and verified /var/adm/messages is located
at /var/sadm/system/logs
- Ran a complete set of caiman hg repo unit tests and verified no
regressions have occurred.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
