Hi,

Can I get another review for bug :
7107775 - install: log the /var/adm/messages from the installation on the target
  http://monaco.us.oracle.com/detail.jsf?cr=7107775

Webrev Located at:
  https://cr.opensolaris.org/action/browse/caiman/mattman/7107775/


Fix is same as before except I've now striped out the common code from AI, GUI and TI and placed it as a separate method that can be commonly used by all three installers into the transfer_files ICT checkpoint code itself.

I was going to place it as a common method in install_common.__init__.py however the import of InstallEngine caused a cicrular import error. Upon thinking it makes more sense to have this contained within the transfer_files ICT code itself.

Testing:
- Built ISO's for AI, TI, GUI and test installed all three ensuring
  /var/adm/messages was delivered to /var/sadm/system/logs.
  Also verified that on all three installs /var/sadm/install/logs is a
  symlink to /var/log/install

- Ran a complete set of caiman hg repo unit tests and verified no
  regressions have occurred.

cheers

Matt
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to