On 01/18/12 07:08 AM, Matt Keenan wrote:
Out of curiousity, why have the exact same code in two different places?
Is there nowhere in install_common this code could go that both the GUI
and TI can call? If not, this solution looks fine to me.
Main reason being that potentially down the line GUI and TI may differ
in the files they require to transfer.
If this is unlikely to happen then I have no problem moving this to
install common.
I noticed that the logic for setting up the dictionary that the
transfer-files ICT interprets
is very similar in the changes you made to GUI and TI for this bug.
This same code also exists
in AI for storing the list of files to be transferred in AI. I think it
would be a good idea to
define a function that sets up the dictionary, allowing its caller to
pass in the values
to be stored in the dictionary. That way, we won't have much duplicate
code regardless
the list of files GUI and TI changes or not. We also have the benefit
of being able to remove
this same code in AI.
Thanks,
--Karen
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
