Hi Karen, The code changes look good to me.
I do have one question about the unmounting here - does it have any negative impact on the OS already running? Should we maybe remount libc after we've finished the transfer? Possibly not necessary, but just wondering... Thanks, Darren. On 22/02/2012 01:01, Karen Tung wrote: > I would like to get a review of my changes for fixing the following bug: > > 7108163 <http://monaco.us.oracle.com/detail.jsf?cr=7108163> Solaris 11 > image fails to boot after switching between x86 CPU models > http://monaco.us.oracle.com/detail.jsf?cr=7108163 > > webrev: > https://cr.opensolaris.org/action/browse/caiman/ktung/umount-bug/webrev/ > > Testing: > - built a x86 text installer image that includes the updated file. > > - Install the ISO in a virtual box running on an intel based x86 system. > Exported the ova. Then, imported > the ova in a virtual box running on an AMD based system. Make sure the > imported > virtual machine instance can boot fully to login prompt, and I can log in. > > - Also install the ISO in a virtual box running on an AMD based system. > Exported the ova. Then, > imported the ova into a virtual box running on an intel based system. Make > sure the imported > virtual machine instance can boot fully to login prompt, and I can log in. > > Thanks, > > --Karen > > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
