Thanks for explaining that.
ginnie

On 02/22/12 11:14 AM, Karen Tung wrote:
Hi Ginnie,

Thank you for the code review.  Please see my comments inline.

On 02/22/12 09:19, Virginia Wray wrote:
Hi Karen --

The code changes look fine.

I profess ignorance here. How does this work
with a non-virtualized install? What I want to
understand is what is the purpose of libc.so.1,
and why did removing it break the VB install?
When the system boots up, the boot process
always try to see if there's an optimized libc for
that processor, if so, the optimized libc will get
mounted over the unoptimized one.

The bug exists because the the optimized libc
for the processor from which the install is done is
copied over.  So, we lost the original unoptimized
libc.  If you were to boot on the same machine,
there's no problem.  However, if you "move" the hard disk
from one machine to another that has a different processor,
and there's not an optimized libc for the processor
on that machine, it needs to use the unoptimized one,
but the unoptimized one is gone.  "Moving the hard disk"
is easy to do on a virtual machine, and that's why
the bug is most visible in that situation.  If you were
to physically remove the hard disk from an actual system
and install it on another system with a different processor,
you will run into this bug too.

So, the fix of the bug is to umount the optimized libc
overlay before we do the cpio, so, the unoptimized
libc gets copied over.

Thanks,

--Karen


thanks,
ginnie




On 02/21/12 06:01 PM, Karen Tung wrote:
I would like to get a review of my changes for fixing the following bug:

7108163 <http://monaco.us.oracle.com/detail.jsf?cr=7108163> Solaris 11 image fails to boot after switching between x86 CPU models
http://monaco.us.oracle.com/detail.jsf?cr=7108163

webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/umount-bug/webrev/

Testing:
- built a x86 text installer image that includes the updated file.

- Install the ISO in a virtual box running on an intel based x86 system. Exported the ova. Then, imported the ova in a virtual box running on an AMD based system. Make sure the imported virtual machine instance can boot fully to login prompt, and I can log in.

- Also install the ISO in a virtual box running on an AMD based system. Exported the ova. Then, imported the ova into a virtual box running on an intel based system. Make sure the imported virtual machine instance can boot fully to login prompt, and I can log in.

Thanks,

--Karen


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to