Hi Karen, * Karen Tung ([email protected]) wrote: > Thanks everyone for reviewing my initial changes for bug 7108163. > > Sanjay pointed out to me privately that the fix only takes care of > unmounting optimized libc overlays for x86. It does not take care > of libc overlays for SPARC. For now, there's no libc overlay for sparc, > so, the fix would still work, but the code will have to be changed > again if we have > a libc overlay for sparc in the future. > > I completely re-implemented my changes to take care of the possibility > of having optimized libc for sparc in the future. > > The updated webrev is below: > https://cr.opensolaris.org/action/browse/caiman/ktung/umount-bug-fix2/webrev/
The only comment I have is a nit. Line 307: remove extraneous 'of' at the beginning of the line Otherwise, looks good to me. Cheers, -- Glenn _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
