Hi,

Could I please get a code review for the following bug and RFE:

7152537 AI fails to install packages with licenses using must-display=true
       and not must-accept=true

7145997 noinstall element should be implemented as reject for
        pkg transfer    

The webrev is at:

  https://cr.opensolaris.org/action/browse/caiman/dkenny/7152537-7145997/webrev/

I've tested by doing AI installs and validating that the GUI and Text
installers are still working as expected too.

I added a couple of basic PyUnit tests too.

Also ran pep8 and pylint on my changes.

FYI, the output changes in AI install look something like:

12:03:22    Creating IPS image
12:03:24    Refreshing Catalog ... Started.
12:03:36    Refreshing Catalog ... Done.
12:03:46    Transfer set to reject packages matching:
12:03:46      file/slocate
12:03:46    Installing packages from:
12:03:46        solaris
12:03:46            origin:  http://pkg.oracle.com/solaris/release/
12:03:46            mirror:  http://pkg-cdn1.oracle.com/solaris/release/
12:03:46        dpk-test
12:03:46            origin:
file:///net/10.169.107.189/export/home/darrenk/test/test_simple_pkg/repo/
12:03:46    Refreshing Catalog ... Started.
12:04:01    Refreshing Catalog ... Done.
12:04:15    Creating Plan ... Started.
12:09:12    Creating Plan ... Done.
12:09:15    Please review the licenses for the following packages post-install:
12:09:15      dpk/test                                 (not displayed)
12:09:15      consolidation/osnet/osnet-incorporation  (automatically accepted,
12:09:15                                                not displayed)
12:09:15    Package licenses may be viewed using the command:
12:09:15      pkg info --license <pkg_fmri>
12:09:16    Download Phase ... Started.


Thanks,

Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to