Updated webrev at:
https://cr.opensolaris.org/action/browse/caiman/dkenny/7152537-7145997-rev2/webrev/
Thanks,
Darren
On Fri Mar 16 13:33:34 2012, Drew Fisher wrote:
>
>
> On 3/16/12 7:24 AM, Darren Kenny wrote:
>> Hi Drew,
>>
>> On Fri Mar 16 13:18:26 2012, Drew Fisher wrote:
>>> Darren,
>>>
>>> ips.py
>>> NIT: We should change the logger printf statements to use "," instead of %
>>> Ex: 638 --> self.logger.info(" %s", pkg)
>> That doesn't work - I would need to make it:
>>
>> self.logger.info(" ", pkg)
>>
>> Is that what you meant?
>
> No, you don't need the '%' character:
>
> >>> import logging
> >>> s = "this is a string"
> >>> logging.error(" %s", s)
> ERROR:root: this is a string
> >>> logging.warning(" %s", s)
> WARNING:root: this is a string
> >>>
>
> Hrm. I wonder if .info() behave differently....
>
> -Drew
>
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
