OK, fixed...
On Fri Mar 16 14:37:15 2012, Drew Fisher wrote:
> Missed a couple:
>
> 695, 697, 702
>
> Also, you can just chain args (no need for a tuple):
>
> >>> import logging
> >>> logging.error("%s %s %s", "cat", "dog", "baz")
> ERROR:root:cat dog baz
>
> Otherwise, this looks good. No need for another webrev.
>
> -Drew
>
> On 3/16/12 7:55 AM, Darren Kenny wrote:
>> Updated webrev at:
>>
>> https://cr.opensolaris.org/action/browse/caiman/dkenny/7152537-7145997-rev2/webrev/
>>
>> Thanks,
>>
>> Darren
>>
>> On Fri Mar 16 13:33:34 2012, Drew Fisher wrote:
>>>
>>> On 3/16/12 7:24 AM, Darren Kenny wrote:
>>>> Hi Drew,
>>>>
>>>> On Fri Mar 16 13:18:26 2012, Drew Fisher wrote:
>>>>> Darren,
>>>>>
>>>>> ips.py
>>>>> NIT: We should change the logger printf statements to use "," instead of
>>>>> %
>>>>> Ex: 638 --> self.logger.info(" %s", pkg)
>>>> That doesn't work - I would need to make it:
>>>>
>>>> self.logger.info(" ", pkg)
>>>>
>>>> Is that what you meant?
>>> No, you don't need the '%' character:
>>>
>>> >>> import logging
>>> >>> s = "this is a string"
>>> >>> logging.error(" %s", s)
>>> ERROR:root: this is a string
>>> >>> logging.warning(" %s", s)
>>> WARNING:root: this is a string
>>> >>>
>>>
>>> Hrm. I wonder if .info() behave differently....
>>>
>>> -Drew
>>>
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
