Hi Niall,
In general, all looks good, just some small comments...
In the file INSTALL_DISK_PANEL.txt:
- there seems to be some weird characters before the title:
1 +Disks and Partitioning
Are these intended? (i.e. are the Unicode or something that didn't come
across in the diff?)
- Is this text completely correct?
IMPORTANT: The installer uses GPT formatting when installing onto a
whole disk or when creating new partitions. However, existing GPT
partitions or DOS partitions are retained by default and displayed in
this panel, so you can retain and install into an existing DOS
partition or into a logical partition within a DOS partition.
It would seem wrong to me to say that it uses GPT formatting when
creating new partitions - surely if the disk has an MBR layout it
won't use GPT...
- For the text:
Note: A DOS partition cannot be larger than 2 TB, in order to be used
for installing the operating system. For disks larger than 2 TB, use
GPT partitioning.
Should we maybe suggest how a user would make this switch (about the
only way I can think of is to use the whole-disk and this would then
use GPT - I don't see any other way)
- With the text :
LINUX-SWAP INSTRUCTIONS: If ...
should this mention that this is only relevant if using a DOS/MBR layout?
In text-install/helpfiles/Makefile, the tabbing seems a little off here for
the new line added (seems to be using spaces not tabs).
In text-install/helpfiles/disk.txt:
- The following text was removed:
The size of each device is displayed in gigabytes
Do we now display the actual size qualifier in the UI? If so, that's
ok to remove, otherwise it should remain.
Thanks,
Darren.
On 17/04/2012 05:21, Niall Power wrote:
> Hi,
>
> Could I ask for a review for the online helpfile integration for GPT
> partitioning in the Text and GUI installers.
> These help files have been provided by Barbara and reviewed by me.
>
> Note that I have not adjusted the permissions of any of the existing
> files (they are already executable) by
> default in slim_source.
>
>
> I've constructed Text & GUI ISO images and confirmed that the help files
> display correctly according to the
> corresponding screens.
>
> Webrev:
> http://jurassic.us.oracle.com/~npower/webrevs/webrev-gpt-helpfiles/
>
> Thanks!
> Niall
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
