Hi Darrenm
On 04/18/12 20:25, Darren Kenny wrote:
On 18/04/2012 10:28, Niall Power wrote:
Hi Darren,
Thanks for reviewing, responses below.
CC:ing Barbara in case she has any additional comments regarding my
responses
On 04/17/12 08:49 PM, Darren Kenny wrote:
Hi Niall,
In general, all looks good, just some small comments...
In the file INSTALL_DISK_PANEL.txt:
- there seems to be some weird characters before the title:
1 +Disks and Partitioning
Are these intended? (i.e. are the Unicode or something that didn't come
across in the diff?)
I don't see anything like that in the actual file itself even when
opening with ASCII encoding,
nor when it displays it in the help view of the GUI installer.
Strange, it's in all the files in the webrev - diffs and the new link...
I logged in to a pure C locale session and while I still wasn't able to
see any visible character, I was able to
"delete" it - gedit or vi didn't display any visual difference but gedit
it flagged that the file had been modified.
And after that the strange character disappeared from the diffs.
New webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-gpt-helpfiles-2
Thanks!
Niall
- Is this text completely correct?
IMPORTANT: The installer uses GPT formatting when installing onto a
whole disk or when creating new partitions. However, existing GPT
partitions or DOS partitions are retained by default and displayed in
this panel, so you can retain and install into an existing DOS
partition or into a logical partition within a DOS partition.
It would seem wrong to me to say that it uses GPT formatting when
creating new partitions - surely if the disk has an MBR layout it
won't use GPT...
I agree, I'm surprised I missed that.
I think it should be as follows:
IMPORTANT: The installer uses GPT formatting when installing onto a
whole disk or an unformatted disk. However, existing GPT partitions
or DOS partitions are retained by default and displayed in this panel,
so you can retain and install into an existing partition
Sounds better to me.
- For the text:
Note: A DOS partition cannot be larger than 2 TB, in order to be used
for installing the operating system. For disks larger than 2 TB, use
GPT partitioning.
Should we maybe suggest how a user would make this switch (about the
only way I can think of is to use the whole-disk and this would then
use GPT - I don't see any other way)
I think this is going to be such a rare occurrence that is not worth
adding into
the help file. If the disk is larger than 2TB the user would have had
to consciously
put an MBR table on it, so they should arguably have the means to
reformat it with GPT
if they already went down that road.
Out of the box>2Tb disks will be either unformatted (my experience to
date) or be GPT formatted.
OK.
- With the text :
LINUX-SWAP INSTRUCTIONS: If ...
should this mention that this is only relevant if using a DOS/MBR layout?
Yes.
I suggest the following correction:
LINUX-SWAP INSTRUCTIONS: If you used a third-party DOS partitioning
tool, then this screen displays a DOS partition named Linux-swap on
which you can install the Oracle Solaris OS. Change the Linux-swap DOS
partition type in the dropdown box to Solaris2.
Better, thanks.
In text-install/helpfiles/Makefile, the tabbing seems a little off here for
the new line added (seems to be using spaces not tabs).
Oops. Fixed :-)
In text-install/helpfiles/disk.txt:
- The following text was removed:
The size of each device is displayed in gigabytes
Do we now display the actual size qualifier in the UI? If so, that's
ok to remove, otherwise it should remain.
We do.
Updated webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-gpt-helpfiles-1/
Great, looks good now, apart from those weird characters, really would like
to be 100% sure they aren't in there - something is putting them in the
webrev and the new file...
Thanks,
Darren.
Thanks!
Niall
Thanks,
Darren.
On 17/04/2012 05:21, Niall Power wrote:
Hi,
Could I ask for a review for the online helpfile integration for GPT
partitioning in the Text and GUI installers.
These help files have been provided by Barbara and reviewed by me.
Note that I have not adjusted the permissions of any of the existing
files (they are already executable) by
default in slim_source.
I've constructed Text& GUI ISO images and confirmed that the help files
display correctly according to the
corresponding screens.
Webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-gpt-helpfiles/
Thanks!
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
