Hi Ginnie,
Thanks for reviewing...
On 04/18/12 02:29 AM, Virginia Wray wrote:
Hi Niall --
This is a nit, but it caught my attention....
in the following 4 files:
x86_fdisk_partitions.txt
x86_fdisk_partitions_select.txt
x86_fdisk_slices.txt
x86_fdisk_slices_select.txt
Two of them removed the x86 reference in the heading and replaced
it with a DOS reference.
This change was in x86_fdisk_partitions.txt and
x86_fdisk_partitions_select.txt
The other two, x86_fdisk_partitions_select.txt and
x86_fdisk_partitions_select.txt, still
have "x86" in the title.
It seems like all four files should be consistent.
Agreed, I have removed those two X86 references. And also modified the
titles to be more precise:
"SOLARIS DOS PARTITION SLICES"
"SELECT SLICE IN SOLARIS DOS PARTITION"
I was also wondering if the fdisk name for the files is accurate
anymore or if the file names should
be changed to reflect the file contents.
I had thought about that but I decided against it for a couple of reasons.
The help file name is not so important to the user since the text
installer loads the appropriate help file
for the user and it is not done manually by the user. But the file name
name does map to some of the python source
file names such as fdisk_partitions.py. We would then need to change
those, and additionally class names defined
inside that reference fdisk etc.
..starts to get a bit risky for the sake of updating the docs which
should be a low risk update.
That's just my take, but I'm happy to make the changes if you feel it
would be best.
Updated webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-gpt-helpfiles-3/
Thanks!
Niall
thanks,
ginnie
On 04/16/12 10:21 PM, Niall Power wrote:
Hi,
Could I ask for a review for the online helpfile integration for GPT
partitioning in the Text and GUI installers.
These help files have been provided by Barbara and reviewed by me.
Note that I have not adjusted the permissions of any of the existing
files (they are already executable) by
default in slim_source.
I've constructed Text & GUI ISO images and confirmed that the help
files display correctly according to the
corresponding screens.
Webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-gpt-helpfiles/
Thanks!
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
