On 4/20/12 4:17 PM, Keith Mitchell wrote:
Hi Drew,
I don't chime in much, but I figured I'd pop in with a comment. Code
looks fine! It might be best user experience to map all the letter
keys, not just the one's found in the list, such that if you hit "M",
and there are no "M" zones in the list, it jumps to "L" or "N".
Since population of ScrollWindow.jump_dict is optional by the author of
the screen, I would want to leave advanced functionality like "jump to
the closest letter" to the author. If we move to automated jump_dict
population, we could certainly add something like that, though.
I also recommend having the code in inner_window.py instead, but it's
easily movable later. (I believe you can call activate_object(...,
jump=True) to maintain current behavior from that context), but that's
just me.
As I am not any sort of expert on the terminalui code, it seems
counter-intuitive to me to place this level of functionality at the
InnerWindow object (conceptually what does setting a key binding buy us
in an InnerWindow?). Can you elaborate why it should be there?
Thanks for coming out of the shadows for the review! I appreciate it!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
