Keith,
After sleeping on it, I realized that filling the 'gaps' between letters
makes sense, especially for lists that scroll off the screen.
I also switched the updating of the key_dict in ScrollWindow to use
dict.fromkeys(). That function rules. I love learning about new
built-in functions!
New webrev here:
https://cr.opensolaris.org/action/browse/caiman/drewfish/7161344_2/webrev/
-Drew
On 4/20/12 4:17 PM, Keith Mitchell wrote:
Hi Drew,
I don't chime in much, but I figured I'd pop in with a comment. Code
looks fine! It might be best user experience to map all the letter
keys, not just the one's found in the list, such that if you hit "M",
and there are no "M" zones in the list, it jumps to "L" or "N".
I also recommend having the code in inner_window.py instead, but it's
easily movable later. (I believe you can call activate_object(...,
jump=True) to maintain current behavior from that context), but that's
just me.
- Keith
On Fri, Apr 20, 2012 at 2:34 PM, Drew Fisher <[email protected]
<mailto:[email protected]>> wrote:
Good afternoon!
I'd like to get some discussion (and a possible code review) for
the following CR:
7161344 <http://monaco.us.oracle.com/detail.jsf?cr=7161344>
ScrollWindows should support letter jumping
https://cr.opensolaris.org/action/browse/caiman/drewfish/CR_7161344/webrev/
This fix adds the ability for ScrollWindows to *optionally* allow
the author to enable "first letter" jumping. I made this optional
because users may not want letter jumping for short scroll
windows. Before going any further, I wanted to see if folks had
issues or concerns with this approach.
If you'd like to try this out do the following:
export
PYTHONPATH=/net/mox.us.oracle.com/tank/code/cr_7161344/proto/root_i386-nd/usr/lib/python2.6/vendor-packages
<http://mox.us.oracle.com/tank/code/cr_7161344/proto/root_i386-nd/usr/lib/python2.6/vendor-packages>
sudo sysconfig create-profile
(don't worry, you're not going to reconfigure your system)
Proceed through the screens until you get to the timezone screen
and try the letter jumping.
Once done, simply hit F9 to exit (when you do this, you'll hit
another bug with ScrollWindows - it's 7160551 but don't worry
about it)
Let me know if you have questions! I'd like to get this in the
gate so Seth stops sending me angry email. :)
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected] <mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
--
Join me in the fight to end AIDS!
http://www.tofighthiv.org/goto/kemitche
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
