Jack:
With your webrev, I did not see the fix for 7161783. Should you also
update the webrev with the fix for 7161783 for summary.py ????
On 06/ 7/12 06:46 PM, Jack Schwartz wrote:
Hi Mary.
Thanks for reminding me... I found a few small issues with pylint,
and realized that the changed aimanifest broke a unit test. I've now
fixed these issues. New code review is at:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7131650_2
Delta:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7131650_2_1
Thanks,
Jack
On 06/06/12 19:05, Mary Ding wrote:
Jack:
Besides pep8, can you confirm that pylint is fine ?? Thanks !!!
----- Original Message -----
From: [email protected]
To: [email protected]
Sent: Wednesday, June 6, 2012 4:35:16 PM GMT -08:00 US/Canada Pacific
Subject: [caiman-discuss] Please review: OCM/ASR screen fixes and
aimanifest.xml add_drivers stanza removal
Hi everyone.
Here is a webrev of some fixes for OCM/ASR screens and one for
removing the add_drivers stanza from ai_manifest.xml.
https://cr.opensolaris.org/action/browse/caiman/schwartz/7131650_1/webrev/
Bug IDs:
7131650 <http://monaco.us.oracle.com/detail.jsf?cr=7131650>
Temporarily remove add_drivers stanza in ai_manifest.xml 7158078
<http://monaco.us.oracle.com/detail.jsf?cr=7158078> GUI Install fails
when bypassing Support registration 7171496
<http://monaco.us.oracle.com/detail.jsf?cr=7171496> installer summary
screens should reflect which of OCM and ASR are configured, if only
one is
7174802 <http://monaco.us.oracle.com/detail.jsf?cr=7174802> Need to
update the vanity url in the S11U installers with respect to OCM
7161785 <http://monaco.us.oracle.com/detail.jsf?cr=7161785>
WPTG_TBT:Lint:CONCAT:Q&A204721:Solaris 11.1 install_s11 T13Y issue in
solaris_install_textinstall.po
Testing:
7158078: Ran GUI installer to the point just before the install with
blanked out email, password and password checkbox. Verified there
were no more tracebacks.
7171496 and 7161785: Ran GUI installer, text installer and sysconfig
with various combinations of email and password, and mimicking
whether OCM and/or ASR were absent from the system, to verify that
the summaries were accurate. (For example, if OCM isn't on the
system, to only say ASR telemetry will be sent, etc.)
7174802: Verified corrected links showed in live CD, sysconfig and
text-installer screens.
Python files are Pep8 clean.
Gate builds cleanly.
Thanks,
Jack
P.S. Dermot gets the credit for 7158078. I'm just his conduit for
testing and pushing.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
