Hi Jack,

I have a couple of questions/comments.

1) I think ai_manifest.xml can be used directly by
users for their AI installations.  I think it will be worthwhile
to do an AI install with the updated ai_manifest.xml just to make sure
that it still works correctly.

2) I am concerned about the changes for 7161785. In there, you did concatenate those strings like they requested in the bug. However, you left all the blank spaces in the strings. I supposed those spaces are used to line up the strings in English. What will the translators do with the spaces? Is the person that filed the bug OK with leaving the spaces?

Thanks,

--Karen

On 06/06/12 16:36, Jack Schwartz wrote:
Hi everyone.

Here is a webrev of some fixes for OCM/ASR screens and one for removing the add_drivers stanza from ai_manifest.xml.

https://cr.opensolaris.org/action/browse/caiman/schwartz/7131650_1/webrev/

Bug IDs:

7131650 <http://monaco.us.oracle.com/detail.jsf?cr=7131650> Temporarily remove add_drivers stanza in ai_manifest.xml 7158078 <http://monaco.us.oracle.com/detail.jsf?cr=7158078> GUI Install fails when bypassing Support registration 7171496 <http://monaco.us.oracle.com/detail.jsf?cr=7171496> installer summary screens should reflect which of OCM and ASR are configured, if only one is 7174802 <http://monaco.us.oracle.com/detail.jsf?cr=7174802> Need to update the vanity url in the S11U installers with respect to OCM 7161785 <http://monaco.us.oracle.com/detail.jsf?cr=7161785> WPTG_TBT:Lint:CONCAT:Q&A204721:Solaris 11.1 install_s11 T13Y issue in solaris_install_textinstall.po

Testing:

7158078: Ran GUI installer to the point just before the install with blanked out email, password and password checkbox. Verified there were no more tracebacks.

7171496 and 7161785: Ran GUI installer, text installer and sysconfig with various combinations of email and password, and mimicking whether OCM and/or ASR were absent from the system, to verify that the summaries were accurate. (For example, if OCM isn't on the system, to only say ASR telemetry will be sent, etc.)

7174802: Verified corrected links showed in live CD, sysconfig and text-installer screens.

Python files are Pep8 clean.
Gate builds cleanly.

    Thanks,
    Jack

P.S. Dermot gets the credit for 7158078. I'm just his conduit for testing and pushing.


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to