Hi Geoffrey -- Just one comment on the disk_selection.py file.
Mary did a bug fix not too long ago. It was 7170341. There was a discussion regarding padded spaces in the static string, such as what is at line 76. Takashi said that it would be more appropriate for internationalization to eliminate padding spaces from the static string and doing dynamic padding. I think Mary was going to follow up on this. Can check and see if that would apply in this case as well? Other than that, your changes look fine. thanks, ginnie On 06/11/12 03:28 PM, Geoffrey Hart wrote:
Afternoon all! Could I please have a code review for: BUG: 7097153 Advice seems oddly small for solaris partition CODE REVIEW: https://cr.opensolaris.org/action/browse/caiman/ghart/UpdateDiskSizeText/ DESCRIPTION: Wording improvement for the recommended disk size. Before it listed the "minimum" and "recommended" size. The new wording makes it clear that what we are showing is the "minimum" and "recommended minimum" size. TESTING: - Confirmed that new test appears in the text and gui installer. - Verified that the install still succeeds and the OS boots correctly after install. Thanks, Geoffrey _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
