Hi Ginnie,
Regarding current case, the spaces look for indentation and not
padding (for alignment between labels) so problem could be less
than in the padding case. But it's still better to move
the spaces outside of _() so how about to do like this:
+ REC_SIZE_TEXT = _("Recommended minimum: ")
+ self._size_line = DiskScreen.MIN_SIZE_TEXT + min_size_str + \
+ " " + DiskScreen.REC_SIZE_TEXT + rec_size_str
There are two typical types of use of spaces in string literal:
(1) padding for alignment between labels
(2) indentation
As Jack said, key (more problematic) is (1) for localizable strings.
It's often not clear the spaces are for padding for alignment, which
string to align with, and also the other string's length can be changed
when localized.
Spaces for (2) is usually no need to adjust number of spaces so less
problematic than in (1), but it's better to exclude the spaces from
localizable string (move it out from _()).
Thanks,
Takeshi
On 2012年06月13日 02:19, Jack Schwartz wrote:
Hi Geoffrey.
Regarding Ginnie's comment: Takeshi-san told me the same thing about padding.
The issue is that while the padding may be good for the C locale, it will won't
accommodate words of different lengths from other languages. The key is to do
dynamic padding, and adjust the offset of the right-side words based on the
length of the largest left-side word. For an example, please highlighted lines
from 463-497 of support.py see my latest code review:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7162609_2/webrev.2a/
Thanks,
Jack
On 06/12/12 09:36, Virginia Wray wrote:
Hi Geoffrey --
Just one comment on the disk_selection.py file.
Mary did a bug fix not too long ago. It was 7170341.
There was a discussion regarding padded spaces in
the static string, such as what is at line 76.
Takashi said that it would be more appropriate for
internationalization to eliminate padding spaces from
the static string and doing dynamic padding.
I think Mary was going to follow up on this. Can check
and see if that would apply in this case as well?
Other than that, your changes look fine.
thanks,
ginnie
On 06/11/12 03:28 PM, Geoffrey Hart wrote:
Afternoon all!
Could I please have a code review for:
BUG: 7097153 Advice seems oddly small for solaris partition
CODE REVIEW:
https://cr.opensolaris.org/action/browse/caiman/ghart/UpdateDiskSizeText/
DESCRIPTION: Wording improvement for the recommended disk size. Before it listed the "minimum" and
"recommended" size. The new wording makes it clear that what we are showing is the "minimum" and
"recommended minimum" size.
TESTING:
- Confirmed that new test appears in the text and gui installer.
- Verified that the install still succeeds and the OS boots correctly after
install.
Thanks,
Geoffrey
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
