Hi Mary,
On 06/27/12 04:18, Mary Ding wrote:
Nirmal:
Beside pep8, did you run pylint to make sure there are no issues ?? Thanks !!!
Yes I ran pylint and the output remains unchanged. Apologies I forgot to
mention that earlier.
Regards
Nirmal
----- Original Message -----
From: [email protected]
To: [email protected]
Sent: Tuesday, June 26, 2012 2:05:15 PM GMT -08:00 Tijuana / Baja California
Subject: [caiman-discuss] CR request for dhcp cr's
Hi all
Can I please get code review for below dhcp related CR's :
7130777 installadm should allow Administrators to disable modification
of the DHCP configuration file
7173043 dhcp smf service goes into maintenance after delete-client
7151276 installadm should try to preserve existing dhcp entry data where
possible
Webrev Location :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/dhcp-crs/webrev/
Testing :
Pep8 clean
Slim test : Pass
Manual Testing :
/net/indiana-build.us.oracle.com/export/home/na210770/ai/dhcp/Manual-Testing.txt
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
