I just had about half of what's in Sue's email written, so… I'll simply agree with her observations.
One thing as an aside, for posterity's sake - it's getting a bit messy in the DHCP configuration text processing code, but at this point there isn't much to do about it. Maybe we can consider cleaning this up (or fully replacing it) when we move to using a new AI RAD interface. On Jun 26, 2012, at 5:02 PM, Nirmal Agarwal wrote: > Hi all > > Can I please get code review for below dhcp related CR's : > > 7130777 installadm should allow Administrators to disable modification of the > DHCP configuration file > 7173043 dhcp smf service goes into maintenance after delete-client > 7151276 installadm should try to preserve existing dhcp entry data where > possible > > Webrev Location : > https://cr.opensolaris.org/action/browse/caiman/nirmal27/dhcp-crs/webrev/ > > Testing : > Pep8 clean > > Slim test : Pass > > Manual Testing : > /net/indiana-build.us.oracle.com/export/home/na210770/ai/dhcp/Manual-Testing.txt > > Thanks > Nirmal > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
