On 06/27/12 03:05 PM, Sue Sohn wrote:
On 06/26/12 02:02 PM, Nirmal Agarwal wrote:
Hi all
Can I please get code review for below dhcp related CR's :
7130777 installadm should allow Administrators to disable
modification of the DHCP configuration file
7173043 dhcp smf service goes into maintenance after delete-client
7151276 installadm should try to preserve existing dhcp entry data
where possible
Webrev Location :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/dhcp-crs/webrev/
Testing :
Pep8 clean
Slim test : Pass
Manual Testing :
/net/indiana-build.us.oracle.com/export/home/na210770/ai/dhcp/Manual-Testing.txt
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Nirmal,
General comment:
You are adding new strings beyond the G11n message freeze (b19).
This should be OK for these messages. The initial freeze is for large
content, and usually applies outside the scope of CLIs. These messages
might miss the cutoff, but at the most they get translated to Japanese
and simpl. Chinese. We should be OK, regardless.
I'll take some of the blame for this coming in late - I was helping
Nirmal drive this, and due to some downtime I fell behind. All said, we
should be Ok with these messages, though.
Best
Jesse
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
