Hi Sameera, I wonder whether my reply was not communicated properly. If that's the case, I will work on improving that aspect :). Please take it in good spirit.
On Tue, Feb 21, 2012 at 12:21 PM, Sameera Jayasoma <same...@wso2.com> wrote: > Hi Tharindu, > > > On Tue, Feb 21, 2012 at 11:55 AM, Tharindu Mathew <thari...@wso2.com>wrote: > >> Hi Sameera, >> >> We are picking on logging here > > > We are not picking any particular component, team or developer. Yesterday > we came across this while fixing a build failure. Hence thought of > removing this dependency. If anyone thinks that we are picking on stuff, > then please advice us on the correct ways to handle such cases. > It's ok to pick on logging, if they have done a wrong thing. It is totally acceptable, as it's constructive. No developer or team would/should take it personally. > > >> but there are many more. > > > Yes. There are many more. And we can't solve EVERYTHING at once. It > should be a step by step process. Identifying small improvements one by one > and fixing them. > You broke down my single sentence :). I never said about solving EVERYTHING at once. Of course, being incremental or doing it all at once (maybe in a hackathon mode) is just a choice in execution. > > >> Do you have a list of bundles we want to remove to make Carbon a proper >> minimum kernel? > > > Nope. I am afraid we don't have. In fact we don't have to completely > minimize Kernel for 4.0.0 release. Proper minimization will happen for > 5.0.0 release as per the release plans. Therefore for Carbon 4.0.0, the > plan is to fix these small cases and make it ready for a > proper minimization. > > We would appreciate the cooperation from all the developer on this effort. > I wasn't aware of this. I thought it was a Carbon 4.0.0 effort. Sorry, if I missed a mail on this. I was interested in using a minimum kernel asap, but this is not urgent so 5.0.0 is good enough. IMO, the more systematic way would be to check and list what should be removed. Then, there's a lesser chance of us missing any part of the current kernel that should be removed. > > > Thanks, > Sameera. > > > >> >> On Tue, Feb 21, 2012 at 11:52 AM, Amani Soysa <am...@wso2.com> wrote: >> >>> >>> >>> On Tue, Feb 21, 2012 at 11:51 AM, Tharindu Mathew <thari...@wso2.com>wrote: >>> >>>> >>>> >>>> On Tue, Feb 21, 2012 at 11:47 AM, Sameera Jayasoma <same...@wso2.com>wrote: >>>> >>>>> >>>>> >>>>> On Tue, Feb 21, 2012 at 11:32 AM, Amani Soysa <am...@wso2.com> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Tue, Feb 21, 2012 at 11:24 AM, Sameera Jayasoma >>>>>> <same...@wso2.com>wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, Feb 21, 2012 at 11:16 AM, Thilina Buddhika < >>>>>>> thili...@wso2.com> wrote: >>>>>>> >>>>>>>> [Sorry, the subject was accidentally removed when sending out the >>>>>>>> email.] >>>>>>>> >>>>>>>> On a side note, I think we have some classes inside Carbon core >>>>>>>> which are not really a part of Carbon core functionality, for example >>>>>>>> the >>>>>>>> cache entry implementations like IdentityCacheEntry. With Tomcat >>>>>>>> OSGification, I guess we can move these classes to corresponding >>>>>>>> components >>>>>>>> and allow them to evolve independent of the core. >>>>>>>> >>>>>>> >>>>>>> +1. >>>>>>> >>>>>>> Deep/Amani, Can we remove this appender from the Carbon kernel? >>>>>>> Btw, who will work on removing cache entry functionality from kernel. >>>>>>> >>>>>>> Will do, but where should we keep CassandraAppender?. >>>>>> >>>>> Move it to a component named carbon-logging or any other suitable >>>> name. I don't think this belongs to the kernel. >>>> >>> Ah ok I will remove it from the kernel. >>> >>>> >>>>> >>>>> >>>>>> Since its extending log4jAppender and isn't carbon kernel the best >>>>>> place to put it? >>>>>> >>>>> >>>>> Log4jAppender is an interface which allows to people to extends log4j >>>>> functionality. And this appender is one such implementation which push >>>>> logs >>>>> to the Cassandra database. This appender has nothing to do with Carbon >>>>> kenel, IMHO. Can you please explain why you think, it should be in Carbon >>>>> kernel? >>>>> >>>>> Thanks, >>>>> Sameera. >>>>> >>>>> >>>>> >>>>> >>>>>> Thanks, >>>>>>> Sameera. >>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Thilina >>>>>>>> >>>>>>>> On Tue, Feb 21, 2012 at 10:38 AM, Sameera Jayasoma < >>>>>>>> same...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi Devs, >>>>>>>>> >>>>>>>>> There is a Cassandra log4j appender in Carbon.Utils bundle[1]. Due >>>>>>>>> to this logger, following dependencies has been added to the Carbon >>>>>>>>> kernel. >>>>>>>>> >>>>>>>>> Cassandra >>>>>>>>> Hectore-core >>>>>>>>> libthrift. >>>>>>>>> >>>>>>>>> IMHO, these are unnecessary dependencies to Carbon kernel. We need >>>>>>>>> to move this Cassandra appender to the components level. >>>>>>>>> >>>>>>>>> There are some other cases where we can get rid of unnecessary >>>>>>>>> dependencies from Carbon kernel, These are initial steps towards >>>>>>>>> minimizing >>>>>>>>> Carbon kenel. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Sameera. >>>>>>>>> >>>>>>>>> [1] >>>>>>>>> https://svn.wso2.org/repos/wso2/trunk/carbon/core/org.wso2.carbon.utils/pom.xml >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sameera Jayasoma >>>>>>>>> Technical Lead and Product Manager, WSO2 Carbon >>>>>>>>> >>>>>>>>> WSO2, Inc. (http://wso2.com) >>>>>>>>> email: same...@wso2.com >>>>>>>>> blog: http://tech.jayasoma.org >>>>>>>>> >>>>>>>>> Lean . Enterprise . Middleware >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Carbon-dev mailing list >>>>>>>>> Carbon-dev@wso2.org >>>>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Thilina Buddhika >>>>>>>> Associate Technical Lead >>>>>>>> WSO2 Inc. ; http://wso2.com >>>>>>>> lean . enterprise . middleware >>>>>>>> >>>>>>>> phone : +94 77 44 88 727 >>>>>>>> blog : http://blog.thilinamb.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Thilina Buddhika >>>>>>>> Associate Technical Lead >>>>>>>> WSO2 Inc. ; http://wso2.com >>>>>>>> lean . enterprise . middleware >>>>>>>> >>>>>>>> phone : +94 77 44 88 727 >>>>>>>> blog : http://blog.thilinamb.com >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sameera Jayasoma >>>>>>> Technical Lead and Product Manager, WSO2 Carbon >>>>>>> >>>>>>> WSO2, Inc. (http://wso2.com) >>>>>>> email: same...@wso2.com >>>>>>> blog: http://tech.jayasoma.org >>>>>>> >>>>>>> Lean . Enterprise . Middleware >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Carbon-dev mailing list >>>>>>> Carbon-dev@wso2.org >>>>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Sameera Jayasoma >>>>> Technical Lead and Product Manager, WSO2 Carbon >>>>> >>>>> WSO2, Inc. (http://wso2.com) >>>>> email: same...@wso2.com >>>>> blog: http://tech.jayasoma.org >>>>> >>>>> Lean . Enterprise . Middleware >>>>> >>>>> _______________________________________________ >>>>> Carbon-dev mailing list >>>>> Carbon-dev@wso2.org >>>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Regards, >>>> >>>> Tharindu >>>> >>>> blog: http://mackiemathew.com/ >>>> M: +94777759908 >>>> >>>> >>> >> >> >> -- >> Regards, >> >> Tharindu >> >> blog: http://mackiemathew.com/ >> M: +94777759908 >> >> >> _______________________________________________ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Sameera Jayasoma > Technical Lead and Product Manager, WSO2 Carbon > > WSO2, Inc. (http://wso2.com) > email: same...@wso2.com > blog: http://tech.jayasoma.org > > Lean . Enterprise . Middleware > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Regards, Tharindu blog: http://mackiemathew.com/ M: +94777759908
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
