Planning to drop the following classes: - BindLdapAuthenticationHandler.java - DigestMd5DirContextAuthenticationStrategy.java - FastBindLdapAuthenticationHandler.java - RemoteIpLookupCredentialsToPrincipalResolver.java - SpringLdapUtils.java - CredentialsToLDAPAttributePrincipalResolver.java - BindLdapAuthenticationHandlerTests.java - BindTestConfig.java - FastBindLdapAuthenticationHandlerTests.java - CredentialsToLDAPAttributePrincipalResolverTests.java - LdapUtilTests.java
Should be safe to delete the above since we have replacement components based on ldaptive or use an alternative test strategy. I would argue we need to spend some energy on some LDAP test infrastructure. Daniel recommended we check out com.unboundid.ldap.listener.InMemoryDirectoryServer as a test fixture we could spin up for unit tests. I'm still pretty certain we need some additional test fixtures for platform specific functionality like AD password expiration policy tests, but hopefully we can start small and build up.
Converting the following classes: - LdapConnectionMonitor.java (Renamed) - PoolingLdapConnectionMonitor.java (Renamed)
Maybe git considers them renamed, but they are more correctly quivalent components using ldaptive.
- AbstractLdapPersonDirectoryCredentialsToPrincipalResolver.java - AbstractLdapUsernamePasswordAuthenticationHandler.java
This can be removerd using same rationale as above list of components to be deleted.
Not sure about the following: - LdapServiceRegistryDao.java
+1 to drop. If anyone has a use case for an LDAP store, we'll accept contributions based on ldaptive.
M -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
