I am going to update the NOTICE file per Bill's comments and create the KEYS file for release signing.

Anything else that doesn't look right?

If there are no other concerns, I'll repost the new release snapshots tonight and restart the vote.

Andrus


On Sep 20, 2006, at 11:22 AM, Andrus Adamchik wrote:

Bill, from what I am seeing most of this is covered already. See my comments inline. They are related to the cross-platform download (tar.gz, but the rest should be the same).

Maybe only #3 can be improved, but it is still covered.


On Sep 20, 2006, at 3:43 AM, Bill Dudney wrote:
1) the .sh files in the bin directory are not executable

~/Desktop/cayenne-2.0.1-incubating: ls -l bin/
total 16
-rwxr-xr-x   1 andrus  andrus  2072 Sep 18 20:59 dvmodeler.sh
-rwxr-xr-x   1 andrus  andrus  2619 Sep 18 20:59 modeler.sh


2) the jar names in the lib dir do not have 'incubating' in the name - this might be an issue with the incubator pmc but we do have 'incubating' in the root of the directory structure so it's probably ok

Yeah, I assume assembly names including "incubating" is enough.


3) i could not find the jgoodies, jdom, ongl, scopemvc or hsqldb license files or references anywhere. From what I could find here;

http://incubator.apache.org/guides/releasemanagement.html

it looks to me like we need to explicitly point out that this stuff is not from apache

I looked at the struts release (1.3.5) and they simply put a pointer to the antlr site from their NOTICE file which I think will be good...


~/Desktop/cayenne-2.0.1-incubating: ls doc/licenses/
LICENSE.ashwood.txt LICENSE.eclipse.txt LICENSE.jdom.txt LICENSE.jgoodies.txt LICENSE.scope.txt

They are there, but I guess we should move that to the NOTICE file.



4) the jar files don't have LICENSE & NOTICE files in the META-INF folder - it could be unimportant for these jars as they are not shipped separately, but the maven repo probably needs them (and yes I need to get that done)


~/Desktop/cayenne-2.0.1-incubating: jar tvf lib/cayenne.jar |grep META-INF
     0 Mon Sep 18 20:59:24 EDT 2006 META-INF/
   341 Mon Sep 18 20:59:22 EDT 2006 META-INF/MANIFEST.MF
   528 Wed Jul 19 19:55:58 EDT 2006 META-INF/DISCLAIMER
11358 Wed Jul 19 16:56:12 EDT 2006 META-INF/LICENSE
  2923 Wed Jul 19 16:56:12 EDT 2006 META-INF/NOTICE


Andrus


Reply via email to