On Mon, 28 Feb 2005, Federico Montesino Pouzols wrote:


Hi, I think there is a bug in the destinations list. Here you are the fix:

------
112,113c112,115
<                       if ( getFirstDestination() == ta )
<                               firstDestination = NULL;
---
                      else // ( getFirstDestination() == ta )
                              firstDestination = firstDestination->getNext();
                      if ( lastDestination == ta )
                              lastDestination = prev;
------

I'll fix it in CVS. That's the risk of handcrafted lists :). It is not
the only linked list that is implemented from scratch inside ccRTP. In
general, the idea behind not using std::list and other std:: was
avoiding performance loss (both speed and size). Some of the lists in
ccRTP are quite minimal and some others are quite specialized and
would not directly fit in any std::. These structures are used
frequently enough so as to try to optimize them as much as possible.

Actually, the only std:: used in ccRTP is string, and I would like to
replace it soon with the commmonc++ String.

Thanks for the fix. May I suggest the creation of a commonc++ list container instead? The reason I suggested using std::list is because I thought designing containers for everything is kinda stupid. Reuse existing code. :)


Dan


_______________________________________________ Ccrtp-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/ccrtp-devel

Reply via email to