Danny Backx wrote: > On Sun, 2007-08-05 at 16:08 +0100, Pedro Alves wrote: >> Please move the attribute implementation into either arm.c, or better >> yet, reuse the SUBTARGET_ATTRIBUTE_TABLE mechanism already implemented >> for the "selectany" attribute. Since this is a target specific >> attribute it has no place in the common c code. > > The question is whether this is target specific code. Assuming it is, is > pe.h the right file for it ? >
The pe.h file is also shared by arm-epoc-pe/arm-pe, a different (non Windows) target. I have no idea if EPOC implements SEH the same way as Windows CE, so better place it in wince-pe.h next to the other macros you've implemented. You can do the same macro dance (ARM_PE_SUBTARGET_ATTRIBUTE_TABLE or something). > Also thanks for the pointer, I found how to move the code, that's > straightforward. I've already moved it to pe.h and arm.c in my copy. > arm.c is better, thanks. But notice that the arm_pe_handle_selectany_attribute is in pe.c, perhaps it would be even better. Or better even, a new wince.c file. >> /* This is comment 1. This is comment 2. This is comment 3 that flows into >> a >> new in a new line, and the end comment goes in the same line as the >> last. */ > > The issue with that is that vi implements the comments in the code I > wrote, and apparently it doesn't follow the GNU coding standards. I'll > fix whatever I find to be wrong. > There is got to be some notion of modes/style in vi, isn't there? If there isn't, then ... > Don't tell me to use emacs now though :-) > ... just switch to emacs :) :) (Notice that the GNU coding standards are informally defined as: Whatever emacs does by default. ) Cheers, Pedro Alves ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Cegcc-devel mailing list Cegcc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cegcc-devel
