On Sun, 2007-08-05 at 23:23 +0100, Pedro Alves wrote: > Danny Backx wrote: > > On Sun, 2007-08-05 at 16:08 +0100, Pedro Alves wrote: > >> Please move the attribute implementation into either arm.c, or better > >> yet, reuse the SUBTARGET_ATTRIBUTE_TABLE mechanism already implemented > >> for the "selectany" attribute. Since this is a target specific > >> attribute it has no place in the common c code. > > > > The question is whether this is target specific code. Assuming it is, is > > pe.h the right file for it ? > > > > The pe.h file is also shared by arm-epoc-pe/arm-pe, a different > (non Windows) target. I have no idea if EPOC implements SEH the > same way as Windows CE, so better place it in wince-pe.h next to > the other macros you've implemented. You can do the same macro > dance (ARM_PE_SUBTARGET_ATTRIBUTE_TABLE or something). > > > Also thanks for the pointer, I found how to move the code, that's > > straightforward. I've already moved it to pe.h and arm.c in my copy. > > > > arm.c is better, thanks. But notice that the > arm_pe_handle_selectany_attribute is in pe.c, perhaps it would be even > better. Or better even, a new wince.c file.
Hmm, on the other hand there's only one target attribute table (in
arm.c) so where the functions are is somewhat moot. But declaring them
in arm-protos.h and putting the code in pe.c works.
I didn't find any reference to an epoc platform though.
Danny
--
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ Cegcc-devel mailing list Cegcc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cegcc-devel
