alexfrol added a comment.

In http://reviews.llvm.org/D10536#203421, @compnerd wrote:

> LGTM with the small change to rename isValidAsmValue at least.


All issues are fixed. I'll update the patch soon.

In http://reviews.llvm.org/D10536#203820, @echristo wrote:

> This will need documentation updates yes? Also backend support?
>
> -eric


What documentation updates do you mean?
Backend support is necessary for ‘v’, ‘k’, and ‘Yk’ constraints. They are 
AVX-512 specific and as far as I know work for AVX512 backend support is still 
ongoing.

In http://reviews.llvm.org/D10536#203821, @echristo wrote:

> I don't see a test for the 'k' support or a few other things either. Can you 
> split this out a bit into the various parts for checking the existing 
> constraints, and adding individual ones?
>
> -eric


Sure, will do.


Repository:
  rL LLVM

http://reviews.llvm.org/D10536




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to