> 
> Sending the revised (modulo r155697) patch. Please take a look.
> 
> Codereview: http://codereview.appspot.com/6112056/#ps9001

I think about the only comment I've got is whether or not we should use 
comparison operators instead of == and != in these sorts of cases?

-    Dbg->EmitGlobalVariable(E->getDecl(), Init);
+    if (CGM.getCodeGenOpts().DebugInfo != CodeGenOptions::DebugLineTablesOnly)
+      Dbg->EmitGlobalVariable(E->getDecl(), Init);

I'd prefer it personally. Your thoughts?

-eric
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to