On Sun, Apr 29, 2012 at 3:07 AM, Eric Christopher <[email protected]>wrote:
> > Sending the revised (modulo r155697) patch. Please take a look. > > Codereview: http://codereview.appspot.com/6112056/#ps9001 > > > I think about the only comment I've got is whether or not we should use > comparison operators instead of == and != in these sorts of cases? > > - Dbg->EmitGlobalVariable(E->getDecl(), Init); > + if (CGM.getCodeGenOpts().DebugInfo != > CodeGenOptions::DebugLineTablesOnly) > + Dbg->EmitGlobalVariable(E->getDecl(), Init); > > I'd prefer it personally. Your thoughts? > Yes, the comparison operators look better. Using them now. See attachment and http://codereview.appspot.com/6112056/#ps11001 -- Alexey Samsonov, MSK
issue6112056_11001.diff
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
