On Thu, May 3, 2012 at 11:32 PM, Eric Christopher <[email protected]>wrote:
> > On May 1, 2012, at 8:53 AM, Alexey Samsonov <[email protected]> wrote: > > > > > > > On Sun, Apr 29, 2012 at 3:07 AM, Eric Christopher <[email protected]> > wrote: > >> > >> Sending the revised (modulo r155697) patch. Please take a look. > >> > >> Codereview: http://codereview.appspot.com/6112056/#ps9001 > > > > I think about the only comment I've got is whether or not we should use > comparison operators instead of == and != in these sorts of cases? > > > > - Dbg->EmitGlobalVariable(E->getDecl(), Init); > > + if (CGM.getCodeGenOpts().DebugInfo != > CodeGenOptions::DebugLineTablesOnly) > > + Dbg->EmitGlobalVariable(E->getDecl(), Init); > > > > I'd prefer it personally. Your thoughts? > > > > Yes, the comparison operators look better. Using them now. > > See attachment and http://codereview.appspot.com/6112056/#ps11001 > > One seemingly annoying nit: can you swap the enums so you can use >= > please? I think it makes more sense. Go ahead and commit with that change. > Done. Commited as r156160, thank you! -- Alexey Samsonov, MSK
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
