klimek added a subscriber: klimek. klimek added a comment. Minor nits; I'll want Alex to also take a look, as I had reviewed the original code before, so he probably has more insightful things to say :)
================ Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:1 @@ +1,2 @@ +//===--- GoogleTidyModule.cpp - clang-tidy --------------------------------===// +// ---------------- Fix name. ================ Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:34 @@ +33,3 @@ + ClangTidyOptions Options; + auto &Opts = Options.CheckOptions; + return Options; ---------------- Is this line supposed to do something? ================ Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:40-41 @@ +39,4 @@ +// Register the GoogleTidyModule using this statically initialized variable. +static ClangTidyModuleRegistry::Add<ModernizeModule> X("modernize-module", + "Adds modernize checks."); + ---------------- Please run clang-format over the code :) http://reviews.llvm.org/D11946 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits