Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

[Alexander Kornienko via cfe-commits]

alexfh added inline comments.

================
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:131
@@ +130,3 @@
+  : ClangTidyCheck(Name, Context) {
+    std::string IncludeStyleStr = Options.get("IncludeStyle", "llvm");
+    if (IncludeStyleStr == "llvm") {
----------------
alexfh wrote:
> Please use `llvm::StringSwitch`.
Also, please make `IncludeStyle` const and initialize it in the constructor 
initializer list.


http://reviews.llvm.org/D11946



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits