eugenis added inline comments. ================ Comment at: test/libcxx/test/config.py:444 @@ -442,1 +443,3 @@ + def configure_compile_flags_abi_version(self): + abi_version = self.get_lit_conf('abi_version', '').strip() ---------------- EricWF wrote: > Please allow abi_version to be optional before committing. IE > > ``` > abi_version = self.get_lit_conf('abi_version', None) > if abi_version is not None: > self.cxx.compile_flags += ['-D_LIBCPP_ABI_VERSION=' + abi_version'] > ``` > > That should allow us to put off the changes to libc++abi. OK. This would hold while ABI version is 1.
Repository: rL LLVM http://reviews.llvm.org/D11740 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits