> On Nov 18, 2015, at 4:21 PM, John McCall <rjmcc...@gmail.com> wrote:
> 
> rjmccall added inline comments.
> 
> ================
> Comment at: include/clang/Basic/ObjCRuntime.h:182
> @@ +181,3 @@
> +    switch (getKind()) {
> +    case FragileMacOSX: return false;
> +    case MacOSX: return getVersion() >= VersionTuple(10, 10);
> ----------------
> I went ahead and asked Greg, and he agreed that it's best to not enable this 
> on the Mac fragile runtime.  The functions exist, but they aren't profitable 
> to call, other than a small code-size decrease.
Ah cool.  Thanks for checking.

I’m working on updating the patch now with your feedback.  Should have a new 
version soon.

I will now also add tests to ensure the fragile runtime does not get this 
change, since i’d been missing that before.

Thanks,
Pete
> 
> 
> http://reviews.llvm.org/D14737
> 
> 
> 

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to