ABataev marked 2 inline comments as done.
================
Comment at: lib/Sema/SemaPseudoObject.cpp:232
@@ -231,3 +231,3 @@
/// Return true if assignments have a non-void result.
- bool CanCaptureValue(Expr *exp) {
+ bool CanCaptureValue(Expr *exp) const {
if (exp->isGLValue())
----------------
rjmccall wrote:
> Just make this static.
Ok
================
Comment at: lib/Sema/SemaPseudoObject.cpp:464
@@ -461,1 +463,3 @@
+ if (useSetterResultAsExprResult(result.get()))
+ setResultToLastSemantic();
----------------
rjmccall wrote:
> This will leave the result as the captured set value if it can't capture the
> setter result. Is that desired?
The fact that the value can be captured must be checked in
useSetterResultAsExprResult()
http://reviews.llvm.org/D15174
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
