ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
The wording implies global index support, which is confusing. As most users shouldn't care about this flag, also make it hidden to avoid further confusion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51977 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp =================================================================== --- clangd/tool/ClangdMain.cpp +++ clangd/tool/ClangdMain.cpp @@ -130,10 +130,11 @@ static llvm::cl::opt<bool> EnableIndex( "index", - llvm::cl::desc("Enable index-based features such as global code completion " - "and searching for symbols. " - "Clang uses an index built from symbols in opened files"), - llvm::cl::init(true)); + llvm::cl::desc( + "Enable index-based features. By default, clangd maintains an index " + "built from symbols in opened files. Static/global index support needs " + "to enabled separatedly."), + llvm::cl::init(true), llvm::cl::Hidden); static llvm::cl::opt<bool> ShowOrigins("debug-origin",
Index: clangd/tool/ClangdMain.cpp =================================================================== --- clangd/tool/ClangdMain.cpp +++ clangd/tool/ClangdMain.cpp @@ -130,10 +130,11 @@ static llvm::cl::opt<bool> EnableIndex( "index", - llvm::cl::desc("Enable index-based features such as global code completion " - "and searching for symbols. " - "Clang uses an index built from symbols in opened files"), - llvm::cl::init(true)); + llvm::cl::desc( + "Enable index-based features. By default, clangd maintains an index " + "built from symbols in opened files. Static/global index support needs " + "to enabled separatedly."), + llvm::cl::init(true), llvm::cl::Hidden); static llvm::cl::opt<bool> ShowOrigins("debug-origin",
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits